From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50837 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PaSbY-0006zw-GI for qemu-devel@nongnu.org; Wed, 05 Jan 2011 07:36:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PaSbX-00055o-GD for qemu-devel@nongnu.org; Wed, 05 Jan 2011 07:36:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PaSbX-00055g-9b for qemu-devel@nongnu.org; Wed, 05 Jan 2011 07:36:39 -0500 Message-ID: <4D2465D3.1030609@redhat.com> Date: Wed, 05 Jan 2011 13:36:35 +0100 From: Jes Sorensen MIME-Version: 1.0 References: <1294224062-18745-1-git-send-email-Jes.Sorensen@redhat.com> <20110105123438.GA21883@redhat.com> In-Reply-To: <20110105123438.GA21883@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: armbru@redhat.com, agraf@suse.de, qemu-devel@nongnu.org On 01/05/11 13:34, Michael S. Tsirkin wrote: > On Wed, Jan 05, 2011 at 11:41:02AM +0100, Jes.Sorensen@redhat.com wrote: >> From: Jes Sorensen >> >> strtosz() needs to return a 64 bit type even on 32 bit >> architectures. Otherwise qemu-img will fail to create disk >> images >= 2GB >> >> Signed-off-by: Jes Sorensen > > Nothing wrong with this patch, but should the function > be renamed to strtos64 then? I don't think that adds any value to be honest. The problem with the old interface was that the return type differed depending on whether it was compiled on 32 vs 64 bit systems. Cheers, Jes