From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55154 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PbEhi-00070L-W9
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 10:58:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PbEhh-0005pS-8R
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 10:58:14 -0500
Received: from fmmailgate03.web.de ([217.72.192.234]:57327)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PbEhh-0005pG-15
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 10:58:13 -0500
Message-ID: <4D2737EB.6070002@web.de>
Date: Fri, 07 Jan 2011 16:57:31 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig12C9F19F22B4529E4C287FDA"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] qemu-kvm vs. qemu: Terminate cpu loop on reset?
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: kvm <kvm@vger.kernel.org>
Cc: qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig12C9F19F22B4529E4C287FDA
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Hi,

does anyone immediately know if this hunk from vl.c

@@ -1278,6 +1197,10 @@ void qemu_system_reset_request(void)
     } else {
         reset_requested =3D 1;
     }
+    if (cpu_single_env) {
+        cpu_single_env->stopped =3D 1;
+        cpu_exit(cpu_single_env);
+    }
     qemu_notify_event();
 }

is (semantically) relevant for upstream as well? IIUC, it ensures that
the kvm cpu loop is not continued if an IO access called into
qemu_system_reset_request.

If yes, then it would be a good time to push a patch: these bits will
fall to dust on next merge from upstream (vl.c no longer has access to
the cpu state).

Jan


--------------enig12C9F19F22B4529E4C287FDA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk0nN+sACgkQitSsb3rl5xQV2QCg6sh6xvohGf92+T1hQs/bZJSY
rSgAoJ6tM3BAjB+GXiP7TGgefdzP+NMl
=QuAP
-----END PGP SIGNATURE-----

--------------enig12C9F19F22B4529E4C287FDA--