From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50419 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PbEoQ-0003G2-DV
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 11:05:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PbEn8-0006tR-BB
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 11:03:51 -0500
Received: from fmmailgate03.web.de ([217.72.192.234]:36676)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PbEn7-0006tM-VT
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 11:03:50 -0500
Message-ID: <4D273965.1090609@web.de>
Date: Fri, 07 Jan 2011 17:03:49 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <20110107071815.26658.403.stgit@s20.home>
	<20110107155817.12891.70829.stgit@s20.home>
In-Reply-To: <20110107155817.12891.70829.stgit@s20.home>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig973F926521120B58B9F9E44C"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH V2] savevm: use error_report for
	vmstate_save error
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig973F926521120B58B9F9E44C
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Am 07.01.2011 16:58, Alex Williamson wrote:
> If migration is done in the background with the -d option, mon is
> NULL and this error message is lost.  Instead use error_report().
>=20
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

As already at it: Is this the only error during migration that can get
lost this way?

Jan

> ---
>=20
>  savevm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/savevm.c b/savevm.c
> index 90aa237..148871d 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1543,7 +1543,7 @@ int qemu_savevm_state_complete(Monitor *mon, QEMU=
File *f)
> =20
>          r =3D vmstate_save(f, se);
>          if (r < 0) {
> -            monitor_printf(mon, "cannot migrate with device '%s'\n", s=
e->idstr);
> +            error_report("cannot migrate with device '%s'\n", se->idst=
r);
>              return r;
>          }
>      }
>=20



--------------enig973F926521120B58B9F9E44C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk0nOWUACgkQitSsb3rl5xTVrACcDwk72sOSDBvuh7CykPeY3uJQ
7MQAnA15z8wIzaObG8Hv0FybpGHa48wY
=5KZK
-----END PGP SIGNATURE-----

--------------enig973F926521120B58B9F9E44C--