From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59546 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PbF9l-0003Kr-8a for qemu-devel@nongnu.org; Fri, 07 Jan 2011 11:27:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PbF9j-000443-U1 for qemu-devel@nongnu.org; Fri, 07 Jan 2011 11:27:12 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:60022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PbF9j-00043O-Ip for qemu-devel@nongnu.org; Fri, 07 Jan 2011 11:27:11 -0500 Message-ID: <4D273EDE.1070003@web.de> Date: Fri, 07 Jan 2011 17:27:10 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20110107071815.26658.403.stgit@s20.home> <20110107155817.12891.70829.stgit@s20.home> <4D273965.1090609@web.de> <1294416650.3214.9.camel@x201> In-Reply-To: <1294416650.3214.9.camel@x201> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5030F775B68FE7D6AF96BA4C" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH V2] savevm: use error_report for vmstate_save error List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5030F775B68FE7D6AF96BA4C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 07.01.2011 17:10, Alex Williamson wrote: > On Fri, 2011-01-07 at 17:03 +0100, Jan Kiszka wrote: >> Am 07.01.2011 16:58, Alex Williamson wrote: >>> If migration is done in the background with the -d option, mon is >>> NULL and this error message is lost. Instead use error_report(). >>> >>> Signed-off-by: Alex Williamson >> >> Reviewed-by: Jan Kiszka >> >> As already at it: Is this the only error during migration that can get= >> lost this way? >=20 > On the migration source side, I think so. All the save callbacks are > return void, so device saves aren't allow to fail. The unmigratable > device registration is the only way I know to trigger an error on this > end. Thanks, Hmm, thinking about this again, wouldn't it be a better user experience to check this in advance, at a time where the issuing console is still listening? Jan --------------enig5030F775B68FE7D6AF96BA4C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0nPt4ACgkQitSsb3rl5xQ9kACeIb6FiJrCw0CnUEtYc6trKqsd k7YAoJINggUrnCBOsiSuCd1OKOL4bt5g =8aYk -----END PGP SIGNATURE----- --------------enig5030F775B68FE7D6AF96BA4C--