From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38210 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pbxb7-000221-7N for qemu-devel@nongnu.org; Sun, 09 Jan 2011 10:54:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pbxb5-0008Fu-34 for qemu-devel@nongnu.org; Sun, 09 Jan 2011 10:54:25 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:35178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pbxb4-0008EJ-OF for qemu-devel@nongnu.org; Sun, 09 Jan 2011 10:54:23 -0500 Message-ID: <4D29DA27.9000807@web.de> Date: Sun, 09 Jan 2011 16:54:15 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20110109130125.GA16169@zubnet.me.uk> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2CE57F00E15712EE813A978B" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 2/2] checkpatch: adjust to QEMUisms List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Stuart Brady , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2CE57F00E15712EE813A978B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 09.01.2011 14:24, Blue Swirl wrote: > On Sun, Jan 9, 2011 at 1:01 PM, Stuart Brady wrote: >> On Sun, Jan 09, 2011 at 11:46:33AM +0000, Blue Swirl wrote: >>> Change checkpatch.pl for QEMU use: >>> - Root directory detection >>> - Forbid tabs >>> - Indent at 4 spaces >>> - Allow typedefs >>> - Enforce brace use even for single statement blocks >>> - Don't suggest nonexistent cleanup tools >=20 > BTW, I checked the last 99 commits with the script. The only real > problems I saw were that the script complains that CPP #if statements > are missing braces and the tabs check fires also for old code. I bet that's fixable with a few additional checks. :) >=20 > for i in '' 1 2 3 4 5 6 7 8 9; do for j in 0 1 2 3 4 5 6 7 8 9; do > echo $i$j; git show HEAD~$i$j >a; clear;cat a; perl > checkpatch.pl-0.31+QEMU --root=3D. a; read foo; done; done >=20 >> Could you separate out the coding style changes, please? >> >> Otherwise, it's just 2900 lines added and 2900 lines removed. >=20 > Does git-am understand patches in -M style? Is there a config option? Would be surprising if not. >=20 > Here's the patch with rename detection on for easier commenting: Line-wrapped unfortunately. > diff --git a/checkpatch.pl-0.31 b/checkpatch.pl-0.31+QEMU > similarity index 97% > rename from checkpatch.pl-0.31 > rename to checkpatch.pl-0.31+QEMU I prefer to track the origin in git, not in the file name. For convenience, we need executable(!) checkpath.pl, at least a symbolic link to it. Otherwise, kudos for picking this up! Jan --------------enig2CE57F00E15712EE813A978B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0p2isACgkQitSsb3rl5xRVggCgmU9exHtsRuZkGFO0DkHyZ7Hw zFwAoJrl6gptwwODsQW6oH73sHV6ndda =no66 -----END PGP SIGNATURE----- --------------enig2CE57F00E15712EE813A978B--