From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36407 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PbzLx-0007UG-Pf
	for qemu-devel@nongnu.org; Sun, 09 Jan 2011 12:47:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PbzLg-00029I-JL
	for qemu-devel@nongnu.org; Sun, 09 Jan 2011 12:46:37 -0500
Received: from moutng.kundenserver.de ([212.227.17.10]:52636)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PbzLg-00028k-5W
	for qemu-devel@nongnu.org; Sun, 09 Jan 2011 12:46:36 -0500
Message-ID: <4D29F477.5010001@mail.berlios.de>
Date: Sun, 09 Jan 2011 18:46:31 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] Add checkpatch.pl from Linux kernel
References: <AANLkTikA7LvwTC4o4pSO59O3smHGcAWAjFgkD=0vX_up@mail.gmail.com>
In-Reply-To: <AANLkTikA7LvwTC4o4pSO59O3smHGcAWAjFgkD=0vX_up@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 09.01.2011 12:45, schrieb Blue Swirl:
> Unchanged import from
> http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-0.31
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> checkpatch.pl-0.31 | 2937 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 2937 insertions(+), 0 deletions(-)
> create mode 100644 checkpatch.pl-0.31
>
> diff --git a/checkpatch.pl-0.31 b/checkpatch.pl-0.31
> new file mode 100644
> index 0000000..cd51a65
> --- /dev/null
> +++ b/checkpatch.pl-0.31

[snip]

I appreciate that it will be possible to use scripts like this one
for QEMU, too. Let me just add a small remark.

QEMU's root directory is already crowded with too many files
(at least that's my personal opinion).

Why not use a directory structure similar to Linux and add
the script to scripts/checkpatch.pl? More scripts will follow,
e.g. scripts/get_maintainer.pl, and users will know where they
have to look for these scripts.

Regards,
Stefan