From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34494 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcF4S-0007LQ-3r for qemu-devel@nongnu.org; Mon, 10 Jan 2011 05:33:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcF4Q-00045F-Sf for qemu-devel@nongnu.org; Mon, 10 Jan 2011 05:33:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcF4Q-00044X-La for qemu-devel@nongnu.org; Mon, 10 Jan 2011 05:33:50 -0500 Message-ID: <4D2AE080.9030507@redhat.com> Date: Mon, 10 Jan 2011 11:33:36 +0100 From: Jes Sorensen MIME-Version: 1.0 References: <1294655380-9857-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1294655380-9857-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] cutils: Use int64_t instead of ssize_t for strtosz() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org On 01/10/11 11:29, Stefan Hajnoczi wrote: > The strtosz() function parses byte count strings and converts K, M, G > units. The ssize_t type is not appropriate because block devices need > 64-bit range even on 32-bit hosts. Switch from ssize_t to int64_t. Hmmm I think this is identical to the patch I posted last week :) Cheers, Jes