From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56600 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcH72-0004gc-Bo
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 07:44:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PcH71-0006Dd-8o
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 07:44:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:32702)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PcH70-0006DB-RC
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 07:44:39 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0ACiYcR006340
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 10 Jan 2011 07:44:35 -0500
Message-ID: <4D2AFF30.1060002@redhat.com>
Date: Mon, 10 Jan 2011 13:44:32 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] usb-ccid (v14)
References: <1294482533-16277-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1294482533-16277-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/08/11 11:28, Alon Levy wrote:
> This patchset adds three new devices, usb-ccid, ccid-card-passthru and
> ccid-card-emulated, providing a CCID bus, a simple passthru protocol
> implementing card requiring a client, and a standalone emulated card.
>
> It also introduces a new directory libcaccard with CAC card emulation,
> CAC is a type of ISO 7816 smart card.
>
> Tree for pull: git://anongit.freedesktop.org/~alon/qemu usb_ccid.v14

One nit left which I didn't notice on previous reviews:  It can't be 
disabled at compile time, there is no --disable-smartcard switch.  The 
nss detection needs some tweaks too.  The usual configure behavior in 
qemu is this:

   [ no smarccard option specified ]
         autodetect, i.e. enable smartcard if nss support is found,
         otherwise disable (i.e. what your patch does now).
   --disable-smartcard
         turn off smartcard support.
   --enable-smartcard
         force smartcard support on, if nss isn't present abort
         configure with an error message.

Otherwise it looks works nicely.  Good job.

cheers,
   Gerd