From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] Re: [PATCH 5/7] tcg-i386: Implement deposit operation.
Date: Mon, 10 Jan 2011 11:19:35 -0800 [thread overview]
Message-ID: <4D2B5BC7.8020509@twiddle.net> (raw)
In-Reply-To: <20110110183722.GM17026@hall.aurel32.net>
On 01/10/2011 10:37 AM, Aurelien Jarno wrote:
>> mov y,x
>> deposit y,y,x,8,8
>>
>> So I could simply put a tcg_abort there. It would be up to whoever
>> improves the register allocator to provide some mechanism for a
>> backend to allocate a scratch. What do you think?
>>
>
> Do you have a way to trigger this problem? or a dump of the ops and asm
> output?
IN:
0x408120c4: rlwimi r4,r4,8,16,23
OP:
---- 0x408120c4
deposit_i32 r4,r4,r4,8,8
goto_tb $0x0
movi_i32 nip,$0x408120c8
exit_tb $0x7fbb00ca5758
OUT: [size=52]
0x60294380: mov 0x10(%r14),%ebp
0x60294384: mov %ebp,%ebx
0x60294386: ror $0x8,%ebp
0x60294389: shrd $0x8,%ebx,%ebp
0x6029438d: rol $0x10,%ebp
0x60294390: mov %ebp,0x10(%r14)
0x60294394: jmpq 0x60294399
0x60294399: mov $0x408120c8,%ebp
0x6029439e: mov %ebp,0x25c(%r14)
0x602943a5: mov $0x7fbb00ca5758,%rax
0x602943af: jmpq 0x622b772e
That should do it. This is present in linux-user-test ppc/ls.
This output still contains that allocate-a-scratch path.
r~
next prev parent reply other threads:[~2011-01-10 20:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 22:42 [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation Richard Henderson
2011-01-07 22:42 ` [Qemu-devel] [PATCH 1/7] tcg: Define "deposit" as an optional operation Richard Henderson
2011-01-07 23:48 ` Stuart Brady
2011-01-09 21:38 ` Aurelien Jarno
2011-01-09 22:45 ` Richard Henderson
2011-01-07 22:42 ` [Qemu-devel] [PATCH 2/7] tcg-ppc: Implement deposit operation Richard Henderson
2011-01-07 23:33 ` [Qemu-devel] " malc
2011-01-07 22:42 ` [Qemu-devel] [PATCH 3/7] tcg-hppa: " Richard Henderson
2011-01-07 23:35 ` Stuart Brady
2011-01-07 23:41 ` Richard Henderson
2011-01-07 22:43 ` [Qemu-devel] [PATCH 4/7] tcg-ia64: " Richard Henderson
2011-01-09 22:04 ` [Qemu-devel] " Aurelien Jarno
2011-01-07 22:43 ` [Qemu-devel] [PATCH 5/7] tcg-i386: " Richard Henderson
2011-01-09 21:53 ` [Qemu-devel] " Aurelien Jarno
2011-01-09 22:55 ` Richard Henderson
2011-01-10 0:16 ` Aurelien Jarno
2011-01-10 0:43 ` Richard Henderson
2011-01-10 16:52 ` Aurelien Jarno
2011-01-10 18:37 ` Aurelien Jarno
2011-01-10 19:19 ` Richard Henderson [this message]
2011-01-07 22:43 ` [Qemu-devel] [PATCH 6/7] target-i386: Use " Richard Henderson
2011-01-07 22:43 ` [Qemu-devel] [PATCH 7/7] target-ppc: " Richard Henderson
2011-01-07 23:10 ` [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation Peter Maydell
2011-01-07 23:37 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2011-01-11 3:23 [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation, v2 Richard Henderson
2011-01-11 3:23 ` [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation Richard Henderson
2011-01-25 12:27 ` Edgar E. Iglesias
2011-01-31 8:33 ` Aurelien Jarno
2011-02-08 18:05 ` Richard Henderson
2011-02-09 7:41 ` [Qemu-devel] " Paolo Bonzini
2011-02-09 17:24 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B5BC7.8020509@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).