From: Chris Krumme <Chris.Krumme@windriver.com>
To: qemu-devel@nongnu.org, amit.shah@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation
Date: Mon, 10 Jan 2011 18:01:58 -0600 [thread overview]
Message-ID: <4D2B9DF6.4080908@windriver.com> (raw)
In-Reply-To: <m3pqs4bzjp.fsf@blackfin.pond.sub.org>
On 01/10/2011 08:31 AM, Markus Armbruster wrote:
> Amit Shah<amit.shah@redhat.com> writes:
>
> [...]
>> diff --git a/hw/qdev.c b/hw/qdev.c
>> index 6fc9b02..168d0f6 100644
>> --- a/hw/qdev.c
>> +++ b/hw/qdev.c
>> @@ -185,7 +185,8 @@ int qdev_device_help(QemuOpts *opts)
>> if (!prop->info->parse) {
>> continue; /* no way to set it, don't show */
>> }
>> - error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
>> + error_printf("%s.%s=%s, %s\n", info->name, prop->name,
>> + prop->info->name, prop->desc ?: "");
Hello Amit,
Do we want to add the GCCism here of ?:?
Thanks
Chris
>> }
>> return 1;
>> }
> Output could be made prettier (align the help texts). Preferrably in a
> follow-up commit, because this one's seen enough respins already.
>
> [...]
>
next prev parent reply other threads:[~2011-01-11 0:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 12:22 [Qemu-devel] [PATCH 0/4] [RESEND] [REBASE] Auto-document qdev devices Amit Shah
2011-01-04 12:22 ` [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation Amit Shah
2011-01-10 14:31 ` Markus Armbruster
2011-01-11 0:01 ` Chris Krumme [this message]
2011-01-11 5:16 ` Amit Shah
2011-01-04 12:22 ` [Qemu-devel] [PATCH 2/4] virtio-serial: Add description fields for qdev properties Amit Shah
2011-01-10 14:47 ` Markus Armbruster
2011-01-04 12:22 ` [Qemu-devel] [PATCH 3/4] net.h: Add description fields for qdev properites Amit Shah
2011-01-04 12:22 ` [Qemu-devel] [PATCH 4/4] block_int.h: Provide documentation for common block qdev properties Amit Shah
2011-01-10 14:50 ` [Qemu-devel] [PATCH 0/4] [RESEND] [REBASE] Auto-document qdev devices Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2010-11-25 17:31 Amit Shah
2010-11-25 17:31 ` [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation Amit Shah
2010-09-15 12:36 [Qemu-devel] [PATCH 0/4] First steps towards documenting qdev devices/options Amit Shah
2010-09-15 12:36 ` [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation Amit Shah
2010-09-28 13:52 ` Markus Armbruster
2010-09-28 14:02 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B9DF6.4080908@windriver.com \
--to=chris.krumme@windriver.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).