From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52716 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcRgu-0003WT-RL
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 19:02:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Chris.Krumme@windriver.com>) id 1PcRgt-0006x8-KT
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 19:02:24 -0500
Received: from mail.windriver.com ([147.11.1.11]:54531)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Chris.Krumme@windriver.com>) id 1PcRgt-0006wg-DA
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 19:02:23 -0500
Message-ID: <4D2B9DF6.4080908@windriver.com>
Date: Mon, 10 Jan 2011 18:01:58 -0600
From: Chris Krumme <Chris.Krumme@windriver.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev
	properties for documentation
References: <cover.1294143626.git.amit.shah@redhat.com>	<cover.1294143626.git.amit.shah@redhat.com>	<ad5771296c1d502d349fe8225f09324323b9fcf7.1294143628.git.amit.shah@redhat.com>
	<m3pqs4bzjp.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3pqs4bzjp.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, amit.shah@redhat.com

On 01/10/2011 08:31 AM, Markus Armbruster wrote:
> Amit Shah<amit.shah@redhat.com>  writes:
>
> [...]
>> diff --git a/hw/qdev.c b/hw/qdev.c
>> index 6fc9b02..168d0f6 100644
>> --- a/hw/qdev.c
>> +++ b/hw/qdev.c
>> @@ -185,7 +185,8 @@ int qdev_device_help(QemuOpts *opts)
>>           if (!prop->info->parse) {
>>               continue;           /* no way to set it, don't show */
>>           }
>> -        error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
>> +        error_printf("%s.%s=%s, %s\n", info->name, prop->name,
>> +                     prop->info->name, prop->desc ?: "");
Hello Amit,

Do we want to add the GCCism here of ?:?

Thanks

Chris

>>       }
>>       return 1;
>>   }
> Output could be made prettier (align the help texts).  Preferrably in a
> follow-up commit, because this one's seen enough respins already.
>
> [...]
>