From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: Glauber Costa <glommer@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state
Date: Tue, 11 Jan 2011 06:54:51 +0100 [thread overview]
Message-ID: <4D2BF0AB.4030900@web.de> (raw)
In-Reply-To: <4D2B8FF8.7070600@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
Am 11.01.2011 00:02, Anthony Liguori wrote:
> On 01/10/2011 04:21 PM, Jan Kiszka wrote:
>> Am 10.01.2011 22:06, Jan Kiszka wrote:
>>
>>>> kvmclock should be created with
>>>> kvm_state as a parameter and kvm_vm_ioctl() is passed the stored
>>>> reference. Taking a global reference to kvm_state in machine_init is
>>>> not a bad thing, obviously the machine initialization function needs
>>>> access to the kvm_state.
>>>>
>>> This would also require changing sysbus interfaces for the sake of KVM's
>>> "abstraction". If this is the only way forward, I could look into this.
>>>
>> Actually, there is already a channel to pass pointers to qdev devices:
>> the pointer property hack. I'm not sure we should contribute to its user
>> base or take the chance for a cleanup, but we are not alone with this
>> requirement. Point below remains valid, though.
>>
>
> It probably makes sense to have a KVMBus and not pass it as a property
> but rather have it access it from the KvmBusState.
KVM is orthogonal to the qtree. Some devices like vga (kvm_coalesce_*,
kvm_log_start/stop*) would actually have to be attached to multiple
buses in this model.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-01-11 5:55 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 17:56 [Qemu-devel] [PATCH 00/35] [PULL] qemu-kvm.git uq/master queue Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 01/35] kvm: Enable user space NMI injection for kvm guest Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 02/35] kvm: convert kvm_ioctl(KVM_CHECK_EXTENSION) to kvm_check_extension() Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 03/35] Clean up cpu_inject_x86_mce() Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 04/35] Add "broadcast" option for mce command Marcelo Tosatti
2011-01-09 18:51 ` [Qemu-devel] " Jan Kiszka
2011-01-15 16:24 ` Jan Kiszka
2011-01-06 17:56 ` [Qemu-devel] [PATCH 05/35] Add function for checking mca broadcast of CPU Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 06/35] kvm: introduce kvm_mce_in_progress Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 07/35] kvm: kvm_mce_inj_* subroutines for templated error injections Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 08/35] kvm: introduce kvm_inject_x86_mce_on Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 09/35] kvm: x86: Fix DPL write back of segment registers Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 10/35] kvm: x86: Remove obsolete SS.RPL/DPL aligment Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 11/35] kvm: x86: Prevent sign extension of DR7 in guest debugging mode Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 12/35] kvm: x86: Fix a few coding style violations Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 13/35] kvm: Fix " Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 14/35] kvm: Drop return value of kvm_cpu_exec Marcelo Tosatti
2011-01-08 13:09 ` [Qemu-devel] " Jan Kiszka
2011-01-06 17:56 ` [Qemu-devel] [PATCH 15/35] kvm: Stop on all fatal exit reasons Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 16/35] kvm: Improve reporting of fatal errors Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 17/35] x86: Optionally dump code bytes on cpu_dump_state Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 18/35] kvm: x86: Align kvm_arch_put_registers code with comment Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 19/35] kvm: x86: Prepare kvm_get_mp_state for in-kernel irqchip Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 20/35] kvm: x86: Remove redundant mp_state initialization Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 21/35] kvm: x86: Fix xcr0 reset mismerge Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 22/35] kvm: x86: Refactor msr_star/hsave_pa setup and checks Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 23/35] kvm: x86: Reset paravirtual MSRs Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 24/35] Synchronize VCPU states before reset Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 25/35] kvm: x86: Drop MCE MSRs write back restrictions Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 26/35] kvm: Eliminate KVMState arguments Marcelo Tosatti
2011-01-06 19:24 ` [Qemu-devel] " Anthony Liguori
2011-01-07 9:03 ` Jan Kiszka
2011-01-07 23:27 ` Anthony Liguori
2011-01-08 8:47 ` Jan Kiszka
2011-01-10 19:59 ` Anthony Liguori
2011-01-10 20:12 ` Jan Kiszka
2011-01-10 20:23 ` Anthony Liguori
2011-01-10 20:34 ` Jan Kiszka
2011-01-11 9:01 ` Avi Kivity
2011-01-11 14:00 ` Anthony Liguori
2011-01-11 14:06 ` Alexander Graf
2011-01-11 14:09 ` Anthony Liguori
2011-01-11 14:22 ` Avi Kivity
2011-01-11 14:36 ` Anthony Liguori
2011-01-11 14:56 ` Avi Kivity
2011-01-11 15:12 ` Anthony Liguori
2011-01-11 15:17 ` Alexander Graf
2011-01-11 15:37 ` Avi Kivity
2011-01-11 15:55 ` Anthony Liguori
2011-01-11 16:03 ` Avi Kivity
2011-01-11 16:26 ` Anthony Liguori
2011-01-11 17:05 ` Avi Kivity
2011-01-11 14:24 ` Alexander Graf
2011-01-11 14:18 ` Avi Kivity
2011-01-11 14:28 ` Anthony Liguori
2011-01-11 14:52 ` Avi Kivity
2011-01-10 20:11 ` Anthony Liguori
2011-01-10 20:15 ` Jan Kiszka
2011-01-11 9:17 ` Avi Kivity
2011-01-06 17:56 ` [Qemu-devel] [PATCH 27/35] kvm: x86: Fix !CONFIG_KVM_PARA build Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state Marcelo Tosatti
2011-01-10 20:31 ` Anthony Liguori
2011-01-10 21:06 ` Jan Kiszka
2011-01-10 22:21 ` Jan Kiszka
2011-01-10 23:02 ` Anthony Liguori
2011-01-11 5:54 ` Jan Kiszka [this message]
2011-01-11 8:00 ` Paolo Bonzini
2011-01-11 8:53 ` Gerd Hoffmann
2011-01-11 17:13 ` Jan Kiszka
2011-01-11 9:31 ` Markus Armbruster
2011-01-11 13:54 ` Anthony Liguori
2011-01-12 10:22 ` Avi Kivity
2011-01-12 10:31 ` Jan Kiszka
2011-01-18 14:28 ` Jan Kiszka
2011-01-18 15:04 ` Anthony Liguori
2011-01-18 15:43 ` Jan Kiszka
2011-01-18 15:48 ` Anthony Liguori
2011-01-18 15:54 ` Jan Kiszka
2011-01-18 17:02 ` Alex Williamson
2011-01-18 17:08 ` Jan Kiszka
2011-01-18 17:39 ` Alex Williamson
2011-01-18 15:50 ` Anthony Liguori
2011-01-18 16:01 ` Jan Kiszka
2011-01-18 16:04 ` Anthony Liguori
2011-01-18 16:17 ` Jan Kiszka
2011-01-18 16:37 ` Anthony Liguori
2011-01-18 16:56 ` Jan Kiszka
2011-01-18 17:09 ` Anthony Liguori
2011-01-18 17:20 ` Jan Kiszka
2011-01-18 17:31 ` Anthony Liguori
2011-01-18 17:45 ` Jan Kiszka
2011-01-19 9:48 ` Gerd Hoffmann
2011-01-19 13:11 ` Markus Armbruster
2011-01-19 16:54 ` Anthony Liguori
2011-01-19 17:19 ` Daniel P. Berrange
2011-01-19 17:43 ` Anthony Liguori
2011-01-20 8:44 ` Gerd Hoffmann
2011-01-20 10:33 ` Daniel P. Berrange
2011-01-20 19:42 ` Anthony Liguori
2011-01-20 19:39 ` Anthony Liguori
2011-01-21 8:35 ` Gerd Hoffmann
2011-01-21 10:03 ` Markus Armbruster
2011-01-19 16:53 ` Anthony Liguori
2011-01-19 17:01 ` Daniel P. Berrange
2011-01-19 17:51 ` Anthony Liguori
2011-01-19 18:52 ` Daniel P. Berrange
2011-01-19 18:58 ` Anthony Liguori
2011-01-19 17:35 ` Daniel P. Berrange
2011-01-19 17:42 ` Anthony Liguori
2011-01-19 18:53 ` Daniel P. Berrange
2011-01-19 13:09 ` Markus Armbruster
2011-01-24 8:45 ` Gleb Natapov
2011-01-19 13:15 ` Markus Armbruster
2011-01-19 16:57 ` Anthony Liguori
2011-01-19 17:25 ` Jan Kiszka
2011-01-19 19:32 ` Blue Swirl
2011-01-20 9:33 ` Jan Kiszka
2011-01-20 19:27 ` Blue Swirl
2011-01-20 21:22 ` Jan Kiszka
2011-01-20 21:40 ` Blue Swirl
2011-01-20 21:53 ` Jan Kiszka
2011-01-25 11:10 ` Avi Kivity
2011-01-21 8:46 ` Gerd Hoffmann
2011-01-21 10:05 ` Markus Armbruster
2011-01-21 16:37 ` Blue Swirl
2011-01-21 17:21 ` Jan Kiszka
2011-01-21 18:04 ` Blue Swirl
2011-01-21 18:17 ` Jan Kiszka
2011-01-21 18:49 ` Blue Swirl
2011-01-24 14:08 ` Jan Kiszka
2011-01-24 21:35 ` Blue Swirl
2011-01-24 21:57 ` Jan Kiszka
2011-01-20 19:37 ` Anthony Liguori
2011-01-20 20:02 ` Blue Swirl
2011-01-20 21:42 ` Jan Kiszka
2011-01-20 21:27 ` Jan Kiszka
2011-01-25 11:06 ` Avi Kivity
2011-01-25 14:30 ` Anthony Liguori
2011-01-25 10:34 ` Avi Kivity
2011-01-25 10:27 ` Avi Kivity
2011-01-25 13:58 ` Anthony Liguori
2011-01-12 12:04 ` Markus Armbruster
2011-01-10 23:04 ` Anthony Liguori
2011-01-11 5:55 ` Jan Kiszka
2011-01-06 17:56 ` [Qemu-devel] [PATCH 29/35] kvm: Drop smp_cpus argument from init functions Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 30/35] kvm: Consolidate must-have capability checks Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 31/35] kvm: x86: Rework identity map and TSS setup for larger BIOS sizes Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 32/35] kvm: Flush coalesced mmio buffer on IO window exits Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 33/35] kvm: Do not use qemu_fair_mutex Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 34/35] kvm: x86: Implicitly clear nmi_injected/pending on reset Marcelo Tosatti
2011-01-06 17:56 ` [Qemu-devel] [PATCH 35/35] kvm: x86: Only read/write MSR_KVM_ASYNC_PF_EN if supported Marcelo Tosatti
2011-01-27 14:39 ` [Qemu-devel] [PATCH] kvm: x86: Fix build in absence of KVM_CAP_ASYNC_PF Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2BF0AB.4030900@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).