From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37918 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcXCK-0001D6-Dt for qemu-devel@nongnu.org; Tue, 11 Jan 2011 00:55:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcXCI-0002yx-WA for qemu-devel@nongnu.org; Tue, 11 Jan 2011 00:55:12 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:39037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcXCI-0002xv-KS for qemu-devel@nongnu.org; Tue, 11 Jan 2011 00:55:10 -0500 Message-ID: <4D2BF0AB.4030900@web.de> Date: Tue, 11 Jan 2011 06:54:51 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state References: <4D2B6CB5.9050602@codemonkey.ws> <4D2B74D8.4080309@web.de> <4D2B8662.9060909@web.de> <4D2B8FF8.7070600@linux.vnet.ibm.com> In-Reply-To: <4D2B8FF8.7070600@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF5BBE10D3265D1951C4F2028" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Glauber Costa , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF5BBE10D3265D1951C4F2028 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 11.01.2011 00:02, Anthony Liguori wrote: > On 01/10/2011 04:21 PM, Jan Kiszka wrote: >> Am 10.01.2011 22:06, Jan Kiszka wrote: >> =20 >>>> kvmclock should be created with >>>> kvm_state as a parameter and kvm_vm_ioctl() is passed the stored >>>> reference. Taking a global reference to kvm_state in machine_init = is >>>> not a bad thing, obviously the machine initialization function needs= >>>> access to the kvm_state. >>>> =20 >>> This would also require changing sysbus interfaces for the sake of KV= M's >>> "abstraction". If this is the only way forward, I could look into thi= s. >>> =20 >> Actually, there is already a channel to pass pointers to qdev devices:= >> the pointer property hack. I'm not sure we should contribute to its us= er >> base or take the chance for a cleanup, but we are not alone with this >> requirement. Point below remains valid, though. >> =20 >=20 > It probably makes sense to have a KVMBus and not pass it as a property > but rather have it access it from the KvmBusState. KVM is orthogonal to the qtree. Some devices like vga (kvm_coalesce_*, kvm_log_start/stop*) would actually have to be attached to multiple buses in this model. Jan --------------enigF5BBE10D3265D1951C4F2028 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0r8LAACgkQitSsb3rl5xRKAQCeOYahMlu5uKH7y2EBywuOoVOI YXoAniH+kKa53C/n89J0ROHnf2qH52uA =YmM3 -----END PGP SIGNATURE----- --------------enigF5BBE10D3265D1951C4F2028--