From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39581 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcZzD-0006Ui-Pi for qemu-devel@nongnu.org; Tue, 11 Jan 2011 03:53:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcZzB-0003Lk-6F for qemu-devel@nongnu.org; Tue, 11 Jan 2011 03:53:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcZzA-0003LV-Sf for qemu-devel@nongnu.org; Tue, 11 Jan 2011 03:53:49 -0500 Message-ID: <4D2C1A96.9010109@redhat.com> Date: Tue, 11 Jan 2011 09:53:42 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state References: <4D2B6CB5.9050602@codemonkey.ws> <4D2B74D8.4080309@web.de> <4D2B8662.9060909@web.de> In-Reply-To: <4D2B8662.9060909@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , kvm@vger.kernel.org, Glauber Costa , Marcelo Tosatti , qemu-devel@nongnu.org Hi, > Actually, there is already a channel to pass pointers to qdev devices: > the pointer property hack. I'm not sure we should contribute to its user > base or take the chance for a cleanup, but we are not alone with this > requirement. Point below remains valid, though. It is considered bad/hackish style as you can't create that kind of devices using the -device command line switch (or from a machine description config file some day in the future). So we should not add more uses of this, especially not in patches which are supposed to cleanup things ;) cheers, Gerd