From: Paolo Bonzini <pbonzini@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
qemu list <qemu-devel@nongnu.org>,
Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 5/5] char: Equip the unix/tcp backend to handle nonblocking writes
Date: Tue, 11 Jan 2011 14:38:00 +0100 [thread overview]
Message-ID: <4D2C5D38.3000606@redhat.com> (raw)
In-Reply-To: <2e63b173956da74c9759b57bddb9d2f01053f8b2.1294743490.git.amit.shah@redhat.com>
On 01/11/2011 12:10 PM, Amit Shah wrote:
> + char_set_fd_handlers(s->fd, tcp_chr_read_poll, tcp_chr_read,
> + char_write_unblocked, chr, poll_out);
Would the 4th parameter always be char_write_unblocked? If so, what
about making it hidden within char_set_fd_handlers (also because
char_write_unblocked is static in qemu-char.c).
Paolo
next prev parent reply other threads:[~2011-01-11 13:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 11:10 [Qemu-devel] [PATCH v9 0/5] char: Add support for nonblocking writes Amit Shah
2011-01-11 11:10 ` [Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers Amit Shah
2011-01-11 14:17 ` [Qemu-devel] " Gerd Hoffmann
2011-01-11 17:13 ` [Qemu-devel] " Blue Swirl
2011-01-12 6:07 ` Amit Shah
2011-01-12 18:01 ` Michael Roth
2011-01-12 19:03 ` Blue Swirl
2011-01-13 6:14 ` Amit Shah
2011-01-13 21:29 ` Blue Swirl
2011-01-11 11:10 ` [Qemu-devel] [PATCH 2/5] char: Introduce char_set/remove_fd_handlers() Amit Shah
2011-01-11 14:39 ` [Qemu-devel] " Gerd Hoffmann
2011-01-11 15:38 ` Amit Shah
2011-01-11 15:54 ` Gerd Hoffmann
2011-01-11 17:23 ` Amit Shah
2011-01-12 9:11 ` Gerd Hoffmann
2011-01-11 11:10 ` [Qemu-devel] [PATCH 3/5] char: Add framework for a 'write unblocked' callback Amit Shah
2011-01-11 14:43 ` [Qemu-devel] " Gerd Hoffmann
2011-01-11 11:10 ` [Qemu-devel] [PATCH 4/5] char: Update send_all() to handle nonblocking chardev write requests Amit Shah
2011-01-11 11:10 ` [Qemu-devel] [PATCH 5/5] char: Equip the unix/tcp backend to handle nonblocking writes Amit Shah
2011-01-11 13:38 ` Paolo Bonzini [this message]
2011-01-12 6:16 ` [Qemu-devel] " Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2C5D38.3000606@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).