From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48941 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcePr-00049q-Et
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 08:37:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PcePq-0001fm-0N
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 08:37:39 -0500
Received: from mail-yw0-f45.google.com ([209.85.213.45]:37434)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PcePp-0001fa-QN
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 08:37:37 -0500
Received: by ywl5 with SMTP id 5so9464333ywl.4
	for <qemu-devel@nongnu.org>; Tue, 11 Jan 2011 05:37:37 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D2C5D38.3000606@redhat.com>
Date: Tue, 11 Jan 2011 14:38:00 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1294743490.git.amit.shah@redhat.com>
	<2e63b173956da74c9759b57bddb9d2f01053f8b2.1294743490.git.amit.shah@redhat.com>
In-Reply-To: <2e63b173956da74c9759b57bddb9d2f01053f8b2.1294743490.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/5] char: Equip the unix/tcp backend to
 handle nonblocking writes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu list <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

On 01/11/2011 12:10 PM, Amit Shah wrote:
> +    char_set_fd_handlers(s->fd, tcp_chr_read_poll, tcp_chr_read,
> +                         char_write_unblocked, chr, poll_out);

Would the 4th parameter always be char_write_unblocked?  If so, what 
about making it hidden within char_set_fd_handlers (also because 
char_write_unblocked is static in qemu-char.c).

Paolo