From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55646 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcfOD-0005fG-V9
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 09:40:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PcfOC-0001Sf-CD
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 09:40:01 -0500
Received: from mx1.redhat.com ([209.132.183.28]:5326)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PcfOC-0001SJ-2y
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 09:40:00 -0500
Message-ID: <4D2C6BB2.206@redhat.com>
Date: Tue, 11 Jan 2011 15:39:46 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1294743490.git.amit.shah@redhat.com>
	<0f9330ee99fb9d11639a98d5fb9c01625a15822e.1294743490.git.amit.shah@redhat.com>
In-Reply-To: <0f9330ee99fb9d11639a98d5fb9c01625a15822e.1294743490.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/5] char: Introduce
	char_set/remove_fd_handlers()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

On 01/11/11 12:10, Amit Shah wrote:
> Introduce a char-specific wrapper to qemu_set_fd_handler functions.
> This wrapper is useful to add / remove a write handler easily.  Write
> handlers are only used when the backend is blocked and cannot receive
> any more input.

I'd suggest to add flags to enable/disable handlers to IOHandlerRecord 
instead.  And helper functions to set/clear them of course.

With that in place you also can move the handlers to a separate struct 
simliar to the new QemuChrHandlers struct from patch #1.

cheers,
   Gerd