From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56605 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcfRV-0007rD-4p
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 09:43:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PcfRU-00020s-9I
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 09:43:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17087)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PcfRT-00020k-Uo
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 09:43:24 -0500
Message-ID: <4D2C6C80.80805@redhat.com>
Date: Tue, 11 Jan 2011 15:43:12 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1294743490.git.amit.shah@redhat.com>
	<3b7fddd6f8538bfdcb01f46935f4fc0760296ea6.1294743490.git.amit.shah@redhat.com>
In-Reply-To: <3b7fddd6f8538bfdcb01f46935f4fc0760296ea6.1294743490.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/5] char: Add framework for a 'write
	unblocked' callback
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

   Hi,

> @@ -60,6 +60,9 @@ struct CharDriverState {
>       IOEventHandler *chr_event;
>       IOCanReadHandler *chr_can_read;
>       IOReadHandler *chr_read;
> +    IOHandler *chr_write_unblocked;
> +    void (*update_fd_handlers)(struct CharDriverState *chr,
> +                               bool poll_out);

I think you don't need that callback in the first place if you are able 
to just enable/disable the handlers for a file handle.

cheers,
   Gerd