From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49169 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pcxqt-00084q-Kv for qemu-devel@nongnu.org; Wed, 12 Jan 2011 05:22:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pcxqs-0004x2-Is for qemu-devel@nongnu.org; Wed, 12 Jan 2011 05:22:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pcxqs-0004wr-Am for qemu-devel@nongnu.org; Wed, 12 Jan 2011 05:22:50 -0500 Message-ID: <4D2D80ED.8030405@redhat.com> Date: Wed, 12 Jan 2011 12:22:37 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state References: <4D2B6CB5.9050602@codemonkey.ws> <4D2B74D8.4080309@web.de> <4D2B8662.9060909@web.de> <4D2C60FB.7030009@linux.vnet.ibm.com> In-Reply-To: <4D2C60FB.7030009@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kvm@vger.kernel.org, Glauber Costa , Marcelo Tosatti , Markus Armbruster , qemu-devel@nongnu.org, Jan Kiszka On 01/11/2011 03:54 PM, Anthony Liguori wrote: > > Right, we should introduce a KVMBus that KVM devices are created on. > The devices can get at KVMState through the BusState. There is no kvm bus in a PC (I looked). We're bending the device model here because a device is implemented in the kernel and not in userspace. An implementation detail is magnified beyond all proportions. An ioapic that is implemented by kvm lives in exactly the same place that the qemu ioapic lives in. An assigned pci device lives on the PCI bus, not a KVMBus. If we need a pointer to KVMState, then we must find it elsewhere, not through creating imaginary buses that don't exist. -- error compiling committee.c: too many arguments to function