* [Qemu-devel] [PATCH v2] Avoid divide by zero when there is no block device to migrate
@ 2011-01-12 13:41 Pierre Riteau
2011-01-13 9:01 ` [Qemu-devel] " Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Pierre Riteau @ 2011-01-12 13:41 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, Pierre Riteau
When block migration is requested and no read-write block device is
present, a divide by zero exception is triggered because
total_sector_sum equals zero.
Signed-off-by: Pierre Riteau <Pierre.Riteau@irisa.fr>
---
This v2 fixes a line that was going beyond 80 characters.
block-migration.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index 1475325..60b9fc0 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -350,7 +350,12 @@ static int blk_mig_save_bulked_block(Monitor *mon, QEMUFile *f)
}
}
- progress = completed_sector_sum * 100 / block_mig_state.total_sector_sum;
+ if (block_mig_state.total_sector_sum != 0) {
+ progress = completed_sector_sum * 100 /
+ block_mig_state.total_sector_sum;
+ } else {
+ progress = 100;
+ }
if (progress != block_mig_state.prev_progress) {
block_mig_state.prev_progress = progress;
qemu_put_be64(f, (progress << BDRV_SECTOR_BITS)
--
1.7.3.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-13 8:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-12 13:41 [Qemu-devel] [PATCH v2] Avoid divide by zero when there is no block device to migrate Pierre Riteau
2011-01-13 9:01 ` [Qemu-devel] " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).