From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/4] pci: allow devices being tagged as not hotpluggable.
Date: Thu, 13 Jan 2011 13:12:25 +0100 [thread overview]
Message-ID: <4D2EEC29.1040800@redhat.com> (raw)
In-Reply-To: <m3aaj6uxfl.fsf@blackfin.pond.sub.org>
>> @@ -1620,6 +1620,11 @@ static int pci_qdev_init(DeviceState *qdev, DeviceInfo *base)
>> info->is_bridge);
>> if (pci_dev == NULL)
>> return -1;
>> + if (qdev->hotplugged&& info->no_hotplug) {
>> + qerror_report(QERR_DEVICE_NO_HOTPLUG, info->qdev.name);
>> + do_pci_unregister_device(pci_dev);
>> + return -1;
>> + }
>
> Any particular reason for not check this before
> do_pci_register_device()?
Don't remember, probably not. I think can could be moved up (and loose
the unregister call) and behavior will not change.
cheers,
Gerd
next prev parent reply other threads:[~2011-01-13 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 14:14 [Qemu-devel] [PATCH v2 0/4] add hotplug opt-out option for pci devices Gerd Hoffmann
2011-01-06 14:14 ` [Qemu-devel] [PATCH v2 1/4] pci: allow devices being tagged as not hotpluggable Gerd Hoffmann
2011-01-06 17:52 ` [Qemu-devel] " Michael S. Tsirkin
2011-01-12 12:19 ` [Qemu-devel] " Markus Armbruster
2011-01-13 12:12 ` Gerd Hoffmann [this message]
2011-01-06 14:14 ` [Qemu-devel] [PATCH v2 2/4] piix: tag " Gerd Hoffmann
2011-01-07 14:42 ` Aurelien Jarno
2011-01-12 12:22 ` Markus Armbruster
2011-01-13 12:19 ` Gerd Hoffmann
2011-01-06 14:14 ` [Qemu-devel] [PATCH v2 3/4] vga: tag as not hotplugable Gerd Hoffmann
2011-01-06 14:14 ` [Qemu-devel] [PATCH v2 4/4] qxl: tag as not hotpluggable Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2EEC29.1040800@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).