From: Gerd Hoffmann <kraxel@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 5/5] iohandlers: Add IOHandlerOps struct
Date: Thu, 13 Jan 2011 15:02:37 +0100 [thread overview]
Message-ID: <4D2F05FD.8060609@redhat.com> (raw)
In-Reply-To: <54967ebf79fdbfdb79f12c2d93608ac260a47795.1294923288.git.amit.shah@redhat.com>
Hi,
> + ioh->ops.fd_read_poll = ops->fd_read_poll;
> + ioh->ops.fd_read = ops->fd_read;
> + ioh->ops.fd_write = ops->fd_write;
You can write this as "ioh->ops = *ops" btw.
I guess the long-term plan (to be committed after killing the last user
of the old interface) is to store a pointer to the ops struct instead of
copying it?
cheers,
Gerd
next prev parent reply other threads:[~2011-01-13 14:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 13:00 [Qemu-devel] [PATCH 0/5] iohandlers: Add support for enabling/disabling individual handlers Amit Shah
2011-01-13 13:00 ` [Qemu-devel] [PATCH 1/5] iohandlers: Avoid code duplication Amit Shah
2011-01-13 13:00 ` [Qemu-devel] [PATCH 2/5] iohandlers: Introduce assign_fd_handlers() and remove_fd_handlers Amit Shah
2011-01-13 13:59 ` [Qemu-devel] " Gerd Hoffmann
2011-01-13 14:10 ` Amit Shah
2011-01-13 13:00 ` [Qemu-devel] [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually Amit Shah
2011-01-13 13:55 ` [Qemu-devel] " Gerd Hoffmann
2011-01-13 14:00 ` Amit Shah
2011-01-13 14:08 ` Gerd Hoffmann
2011-01-13 14:18 ` Amit Shah
2011-01-13 14:53 ` Gerd Hoffmann
2011-01-13 13:00 ` [Qemu-devel] [PATCH 4/5] iohandlers: Enable an iohandler only if the associated handler exists Amit Shah
2011-01-13 13:00 ` [Qemu-devel] [PATCH 5/5] iohandlers: Add IOHandlerOps struct Amit Shah
2011-01-13 14:02 ` Gerd Hoffmann [this message]
2011-01-13 14:09 ` [Qemu-devel] " Amit Shah
2011-01-13 14:04 ` [Qemu-devel] Re: [PATCH 0/5] iohandlers: Add support for enabling/disabling individual handlers Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2F05FD.8060609@redhat.com \
--to=kraxel@redhat.com \
--cc=amit.shah@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).