From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58454 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdNlM-0005rE-9Z
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:02:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PdNlK-0000As-Gb
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:02:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PdNlK-0000Af-9m
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:02:50 -0500
Message-ID: <4D2F05FD.8060609@redhat.com>
Date: Thu, 13 Jan 2011 15:02:37 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1294923288.git.amit.shah@redhat.com>
	<54967ebf79fdbfdb79f12c2d93608ac260a47795.1294923288.git.amit.shah@redhat.com>
In-Reply-To: <54967ebf79fdbfdb79f12c2d93608ac260a47795.1294923288.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/5] iohandlers: Add IOHandlerOps struct
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

   Hi,

> +    ioh->ops.fd_read_poll = ops->fd_read_poll;
> +    ioh->ops.fd_read = ops->fd_read;
> +    ioh->ops.fd_write = ops->fd_write;

You can write this as "ioh->ops = *ops" btw.

I guess the long-term plan (to be committed after killing the last user 
of the old interface) is to store a pointer to the ops struct instead of 
copying it?

cheers,
   Gerd