Re: [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings

[David Ahern <daahern@cisco.com>]

On 01/13/11 02:57, Isaku Yamahata wrote:
> How about creating stub functions instead of #ifdefs?
> something like
> 
> pc-stubs.c
> #ifndef CONFIG_VMWARE_VGA
> pci_vmsvga_init()
> {
> 	error ...
> }
> #endif
> #ifndef CONFIG_...
> ...

I wasn't trying to re-architect how the CONFIG_XXXX is implemented; I
only wanted the existing design to actually work. There are a number of
CONFIG settings which exist in name, but cannot in fact be disabled.

David


> 
> 
> On Wed, Jan 12, 2011 at 11:34:29PM -0700, David Ahern wrote:
>> David Ahern (8):
>>   fix 'no such file' error from make_device_config.sh
>>   x86_64 config: fix compile for CONFIG_VMWARE_VGA=n
>>   x86_64 config: fix compile for CONFIG_PARALLEL=n
>>   remove unused parallel_* variables from pc.c
>>   x86_64 config: fix compile for CONFIG_NE2000_ISA=n
>>   x86_64 config: fix compile for CONFIG_VGA_ISA=n
>>   x86_64 config: fix compile for CONFIG_IDE_ISA=n
>>   x86_64 config: fix compile for CONFIG_FDC=n
>>
>>  hw/pc.c               |   21 ++++++++++++++++++---
>>  hw/pc_piix.c          |   11 +++++++++++
>>  make_device_config.sh |    2 +-
>>  3 files changed, 30 insertions(+), 4 deletions(-)
>>
>> -- 
>> 1.7.3.4
>>
>>
>