From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57496 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdOBt-0007xU-P1
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:30:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <daahern@cisco.com>) id 1PdOBs-0008HS-Qq
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:30:17 -0500
Received: from sj-iport-4.cisco.com ([171.68.10.86]:11829)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <daahern@cisco.com>) id 1PdOBs-0008HF-IP
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:30:16 -0500
Message-ID: <4D2F0C76.9000404@cisco.com>
Date: Thu, 13 Jan 2011 07:30:14 -0700
From: David Ahern <daahern@cisco.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling	config
	settings
References: <1294900477-23722-1-git-send-email-daahern@cisco.com>
	<20110113095725.GA14653@valinux.co.jp>
In-Reply-To: <20110113095725.GA14653@valinux.co.jp>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org



On 01/13/11 02:57, Isaku Yamahata wrote:
> How about creating stub functions instead of #ifdefs?
> something like
> 
> pc-stubs.c
> #ifndef CONFIG_VMWARE_VGA
> pci_vmsvga_init()
> {
> 	error ...
> }
> #endif
> #ifndef CONFIG_...
> ...

I wasn't trying to re-architect how the CONFIG_XXXX is implemented; I
only wanted the existing design to actually work. There are a number of
CONFIG settings which exist in name, but cannot in fact be disabled.

David


> 
> 
> On Wed, Jan 12, 2011 at 11:34:29PM -0700, David Ahern wrote:
>> David Ahern (8):
>>   fix 'no such file' error from make_device_config.sh
>>   x86_64 config: fix compile for CONFIG_VMWARE_VGA=n
>>   x86_64 config: fix compile for CONFIG_PARALLEL=n
>>   remove unused parallel_* variables from pc.c
>>   x86_64 config: fix compile for CONFIG_NE2000_ISA=n
>>   x86_64 config: fix compile for CONFIG_VGA_ISA=n
>>   x86_64 config: fix compile for CONFIG_IDE_ISA=n
>>   x86_64 config: fix compile for CONFIG_FDC=n
>>
>>  hw/pc.c               |   21 ++++++++++++++++++---
>>  hw/pc_piix.c          |   11 +++++++++++
>>  make_device_config.sh |    2 +-
>>  3 files changed, 30 insertions(+), 4 deletions(-)
>>
>> -- 
>> 1.7.3.4
>>
>>
>