From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49081 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdOYb-00082s-MV
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:54:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PdOYJ-00087J-BZ
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:53:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17995)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PdOYJ-000870-1E
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:53:27 -0500
Message-ID: <4D2F11DB.5020403@redhat.com>
Date: Thu, 13 Jan 2011 15:53:15 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1294923288.git.amit.shah@redhat.com>
	<1bdf0a5a5de06cfb332ac17c439ef79cabb835db.1294923288.git.amit.shah@redhat.com>
	<4D2F044D.7020709@redhat.com>
	<20110113140057.GC19434@amit-x200.redhat.com>
	<4D2F0773.8060604@redhat.com>
	<20110113141830.GF19434@amit-x200.redhat.com>
In-Reply-To: <20110113141830.GF19434@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be
 enabled/disabled individually
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

   Hi,

>> I can't see such a race window given that most qemu code runs
>> serialized anyway.  If you call assign_fd_handlers() +
>> set_write_fd_action(false) in sequence I can't see how a select call
>> can happen inbetween ...
>
> Not today, but later when we have threads doing this stuff?

Unlikely I think.  Seems we will go offload specific tasks to threads 
using threadlets (especially in the block layer), but I expect the main 
even loop will not be splitted into multiple threads.

>  Should I
> just leave a comment to take care of this for later?

Thats fine I guess.  Or maybe add arguments to assign_fd_handlers() with 
the initial state.

cheers,
   Gerd