From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50010 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PdPma-0000JJ-Ff for qemu-devel@nongnu.org; Thu, 13 Jan 2011 11:12:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PdPmZ-000218-Ka for qemu-devel@nongnu.org; Thu, 13 Jan 2011 11:12:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PdPmZ-0001xV-Di for qemu-devel@nongnu.org; Thu, 13 Jan 2011 11:12:15 -0500 Message-ID: <4D2F2454.4090305@redhat.com> Date: Thu, 13 Jan 2011 18:12:04 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: KVM call agenda for Jan 11 References: <4D2C3B4D.2090709@redhat.com> <4D2C6C78.70606@codemonkey.ws> In-Reply-To: <4D2C6C78.70606@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Chris Wright , qemu-devel@nongnu.org, kvm-devel , quintela@redhat.com On 01/11/2011 04:43 PM, Anthony Liguori wrote: >> - invalidate all buffers for that block device on machine A after >> migration. >> * with NFS, just close + reopen the file (and pray that nobody else >> has it also opened) >> * with block devices: use BLKFLBLK ioctl, and pray that nobody >> else is >> using the device, that device is not a ramdisk, and some more >> things. To add injury to insult, you need to be root to be able >> to issue that ioctl (technically have CAP_SYS_ADMIN). > > > Why isn't fsync() enough for a block device? fsync() is fine on the outgoing side, but not on the incoming side. (the imcoming side might have valid buffers if it was the outgoing side on the previous migration, for example, or because of automatic probing) -- error compiling committee.c: too many arguments to function