From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49770 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdQbW-0001uO-75
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 12:04:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PdQbK-0004Oy-UB
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 12:04:43 -0500
Received: from mail-yi0-f53.google.com ([209.85.218.53]:52369)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PdQbK-0004Os-QP
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 12:04:42 -0500
Received: by yib17 with SMTP id 17so922324yib.12
	for <qemu-devel@nongnu.org>; Thu, 13 Jan 2011 09:04:42 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D2F30A6.4050108@redhat.com>
Date: Thu, 13 Jan 2011 18:04:38 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1294900477-23722-1-git-send-email-daahern@cisco.com>
	<1294900477-23722-9-git-send-email-daahern@cisco.com>
In-Reply-To: <1294900477-23722-9-git-send-email-daahern@cisco.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 8/8] x86_64 config: fix compile for
	CONFIG_FDC=n
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Ahern <daahern@cisco.com>
Cc: qemu-devel@nongnu.org

On 01/13/2011 07:34 AM, David Ahern wrote:
>
> +#ifdef CONFIG_FDC
>       /* floppy type */
>
>       fd0 = fdctrl_get_drive_type(floppy_controller, 0);
> @@ -403,6 +408,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t above_4g_mem_size,
>       val |= 0x02; /* FPU is there */
>       val |= 0x04; /* PS/2 mouse installed */
>       rtc_set_memory(s, REG_EQUIPMENT_BYTE, val);
> +#endif

Isn't it a bit too eager?  The equipment byte should still be set, or 
have you checked with a real machine?

Paolo