From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50187 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdQdR-00036Q-Pr
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 12:06:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PdQdM-0004ih-44
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 12:06:49 -0500
Received: from mail-yw0-f45.google.com ([209.85.213.45]:34047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PdQdL-0004id-Or
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 12:06:48 -0500
Received: by ywl5 with SMTP id 5so649989ywl.4
	for <qemu-devel@nongnu.org>; Thu, 13 Jan 2011 09:06:47 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D2F3122.900@redhat.com>
Date: Thu, 13 Jan 2011 18:06:42 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1294900477-23722-1-git-send-email-daahern@cisco.com>
	<20110113095725.GA14653@valinux.co.jp>
In-Reply-To: <20110113095725.GA14653@valinux.co.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/8] misc cleanups for x86_64 disabling
	config settings
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, David Ahern <daahern@cisco.com>

On 01/13/2011 10:57 AM, Isaku Yamahata wrote:
> How about creating stub functions instead of #ifdefs?

I think David's #ifdef's are okay.  Ultimately what you'd want is to 
drive all this from configuration files, and if this were done you 
wouldn't need stub functions.

Paolo