From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33918 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PdQvY-0002U4-Ax for qemu-devel@nongnu.org; Thu, 13 Jan 2011 12:25:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PdQvX-0008FK-IW for qemu-devel@nongnu.org; Thu, 13 Jan 2011 12:25:36 -0500 Received: from sj-iport-4.cisco.com ([171.68.10.86]:9768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PdQvX-0008Eg-EU for qemu-devel@nongnu.org; Thu, 13 Jan 2011 12:25:35 -0500 Message-ID: <4D2F3588.5040706@cisco.com> Date: Thu, 13 Jan 2011 10:25:28 -0700 From: David Ahern MIME-Version: 1.0 References: <1294900477-23722-1-git-send-email-daahern@cisco.com> <1294900477-23722-9-git-send-email-daahern@cisco.com> <4D2F30A6.4050108@redhat.com> In-Reply-To: <4D2F30A6.4050108@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 8/8] x86_64 config: fix compile for CONFIG_FDC=n List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 01/13/11 10:04, Paolo Bonzini wrote: > On 01/13/2011 07:34 AM, David Ahern wrote: >> >> +#ifdef CONFIG_FDC >> /* floppy type */ >> >> fd0 = fdctrl_get_drive_type(floppy_controller, 0); >> @@ -403,6 +408,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t >> above_4g_mem_size, >> val |= 0x02; /* FPU is there */ >> val |= 0x04; /* PS/2 mouse installed */ >> rtc_set_memory(s, REG_EQUIPMENT_BYTE, val); >> +#endif > > Isn't it a bit too eager? The equipment byte should still be set, or > have you checked with a real machine? > > Paolo A bit to eager. I'll fix. David