From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59939 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PdSkD-0004h9-9r for qemu-devel@nongnu.org; Thu, 13 Jan 2011 14:22:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PdSkB-0004mJ-PE for qemu-devel@nongnu.org; Thu, 13 Jan 2011 14:22:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PdSkB-0004m8-H8 for qemu-devel@nongnu.org; Thu, 13 Jan 2011 14:21:59 -0500 Message-ID: <4D2F50D1.7010702@redhat.com> Date: Thu, 13 Jan 2011 21:21:53 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] paravirtual mouse/tablet References: <4D2ED1C8.7070304@redhat.com> <4D2F25EA.3020606@redhat.com> <4D2F342C.40707@redhat.com> In-Reply-To: <4D2F342C.40707@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: spice-devel , "qemu-devel@nongnu.org" On 01/13/2011 07:19 PM, Gerd Hoffmann wrote: > On 01/13/11 17:18, Avi Kivity wrote: >> On 01/13/2011 12:19 PM, Gerd Hoffmann wrote: >>> Hi, >>> >>> Just throwing a quick writeup into the ring to kickstart the design >>> discussion ;) >>> >>> >>> typedef struct qemu_pvtablet_message { >>> uint32_t size; /* whole message size */ >>> uint32_t type; /* qemu_pvtablet_type */ >>> uint64_t tv_secs; >>> uint64_t tv_usecs; >> >> time relative to what base? > > Guess that needs to be refined ;) > > Just something relative (if available) should good enougth. The > intended purpose is being able to figure how much time passed between > two events, so one can figure whenever two mouse clicks should be > considered a double-click or not. Ideally the timestamps from the > original mouse event in the vnc/spice client would be passed all the > way through to the guest. Didn't check the protocols whenever they > actually support that, but I think we should have this in the protocol > even if they don't ... Ok. We should then specify that the base is arbitrary (and get rid of tv_secs - 2^64 usecs is half a million years, which should be sufficient time to get a fully threaded qemu. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.