From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55856 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdTvo-0007su-Dj
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 15:38:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PdTvn-0002zr-BE
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 15:38:04 -0500
Received: from mail-iw0-f173.google.com ([209.85.214.173]:46896)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PdTvn-0002zn-6q
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 15:38:03 -0500
Received: by iwn40 with SMTP id 40so2186071iwn.4
	for <qemu-devel@nongnu.org>; Thu, 13 Jan 2011 12:38:02 -0800 (PST)
Message-ID: <4D2F62A8.6070807@codemonkey.ws>
Date: Thu, 13 Jan 2011 14:38:00 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] paravirtual mouse/tablet
References: <4D2ED1C8.7070304@redhat.com>	<4D2F1FA3.5030701@codemonkey.ws>	<4D2F24EE.6070505@redhat.com>	<4D2F2AB3.4020907@codemonkey.ws>
	<ignbjl$g3m$1@dough.gmane.org>
In-Reply-To: <ignbjl$g3m$1@dough.gmane.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org

On 01/13/2011 11:09 AM, Paolo Bonzini wrote:
> On 01/13/2011 05:39 PM, Anthony Liguori wrote:
>> On 01/13/2011 10:14 AM, Avi Kivity wrote:
>>> On 01/13/2011 05:52 PM, Anthony Liguori wrote:
>>>>
>>>> /* host->guest, sent before any other events */
>>>> typedef struct qemu_pvtablet_init {
>>>> uint32_t res_x; /* x axis resolution */
>>>> uint32_t res_y; /* y axis resolution */
>>>> uint32_t features; /* qemu_pvtablet_features */
>>>
>>> uint32_t available_buttons; /* bitmask */
>>
>> Yes, I had intended to do that but left it out.
>>
>> Should it be a bitmask or just a button count? Buttons really have no
>> standard meaning so usually a button count is sufficient.
>
> 3/4 are the mouse wheel, so if you had a mouse with 5 buttons and no 
> wheel those would be buttons 0/1/2/5/6.

It can still be reported as a 7 button mouse but I don't really mind 
either way.

Regards,

Anthony Liguori

> Paolo
>
>