From: Paolo Bonzini <pbonzini@redhat.com>
To: David Ahern <daahern@cisco.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 6/8] x86_64 config: fix compile for CONFIG_VGA_ISA=n
Date: Fri, 14 Jan 2011 08:31:51 +0100 [thread overview]
Message-ID: <4D2FFBE7.407@redhat.com> (raw)
In-Reply-To: <4D2F3634.9040804@cisco.com>
On 01/13/2011 06:28 PM, David Ahern wrote:
>>> @@ -1087,8 +1087,10 @@ void pc_vga_init(PCIBus *pci_bus)
>>> } else if (std_vga_enabled) {
>>> if (pci_bus) {
>>> pci_vga_init(pci_bus);
>>> +#ifdef CONFIG_VGA_ISA
>>> } else {
>>> isa_vga_init();
>>> +#endif
>>
>> Should this be an abort for #ifndef CONFIG_VGA_ISA? And maybe the isapc
>> machine should be disabled altogether?
>>
>> Paolo
>
> If that's desired I can change that to:
>
> #ifdef CONFIG_VGA_ISA
> } else {
> isa_vga_init();
> #else
> abort();
> #endif
Please check if you can trigger the abort via -M isapc (I think so, but
I'm not sure). If I am correct, the better solution is to disable isapc.
Paolo
next prev parent reply other threads:[~2011-01-14 7:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 6:34 [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 1/8] fix 'no such file' error from make_device_config.sh David Ahern
2011-01-13 13:43 ` Markus Armbruster
2011-01-13 14:40 ` David Ahern
2011-01-14 10:34 ` Markus Armbruster
2011-01-14 15:13 ` David Ahern
2011-01-14 19:57 ` Stefan Weil
2011-01-14 22:01 ` Blue Swirl
2011-01-13 6:34 ` [Qemu-devel] [PATCH 2/8] x86_64 config: fix compile for CONFIG_VMWARE_VGA=n David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 3/8] x86_64 config: fix compile for CONFIG_PARALLEL=n David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 4/8] remove unused parallel_* variables from pc.c David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 5/8] x86_64 config: fix compile for CONFIG_NE2000_ISA=n David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 6/8] x86_64 config: fix compile for CONFIG_VGA_ISA=n David Ahern
2011-01-13 17:02 ` [Qemu-devel] " Paolo Bonzini
2011-01-13 17:28 ` David Ahern
2011-01-14 7:31 ` Paolo Bonzini [this message]
2011-01-14 17:49 ` David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 7/8] x86_64 config: fix compile for CONFIG_IDE_ISA=n David Ahern
2011-01-13 6:34 ` [Qemu-devel] [PATCH 8/8] x86_64 config: fix compile for CONFIG_FDC=n David Ahern
2011-01-13 17:04 ` [Qemu-devel] " Paolo Bonzini
2011-01-13 17:25 ` David Ahern
2011-01-13 9:57 ` [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings Isaku Yamahata
2011-01-13 14:30 ` David Ahern
2011-01-13 17:06 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2FFBE7.407@redhat.com \
--to=pbonzini@redhat.com \
--cc=daahern@cisco.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).