From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49202 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdlLj-00026z-34
	for qemu-devel@nongnu.org; Fri, 14 Jan 2011 10:14:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <daahern@cisco.com>) id 1PdlLh-00067X-LU
	for qemu-devel@nongnu.org; Fri, 14 Jan 2011 10:13:58 -0500
Received: from sj-iport-1.cisco.com ([171.71.176.70]:63430)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <daahern@cisco.com>) id 1PdlLh-00067M-DV
	for qemu-devel@nongnu.org; Fri, 14 Jan 2011 10:13:57 -0500
Message-ID: <4D306832.4060704@cisco.com>
Date: Fri, 14 Jan 2011 08:13:54 -0700
From: David Ahern <daahern@cisco.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/8] fix 'no such file' error from
	make_device_config.sh
References: <1294900477-23722-1-git-send-email-daahern@cisco.com>	<1294900477-23722-2-git-send-email-daahern@cisco.com>	<m3ipxshqb1.fsf@blackfin.pond.sub.org>
	<4D2F0EF6.7050905@cisco.com> <m3vd1r7p0d.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3vd1r7p0d.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org



On 01/14/11 03:34, Markus Armbruster wrote:

>>> What about:
>>>
>>> diff --git a/make_device_config.sh b/make_device_config.sh
>>> index 596fc5b..711829c 100644
>>> --- a/make_device_config.sh
>>> +++ b/make_device_config.sh
>>> @@ -18,7 +18,7 @@ process_includes () {
>>>  
>>>  f=$src
>>>  while [ -n "$f" ] ; do
>>> -  f=`tr -d '\r' < $f | awk '/^include / {ORS=" "; print "'$src_dir'/" $2}'`
>>> +  f=`tr -d '\r' <"$f" | awk '/^include / {print "'$src_dir'/" $2}'`
>>>    [ $? = 0 ] || exit 1
>>>    all_includes="$all_includes $f"
>>>  done
>>
>> That works too.
> 
> Care to respin your patch?

done.

> 
>> Any idea why the '%/config-devices.mak' rule does not work for a build
>> directory != src directory?
>>
>> e.g., src=/my/qemu.git, build=/tmp/build-qemu
>>
>> x86_64-softmmu/config-devices.mak is not created, so
>> config-all-devices.mak is empty and the build blows up.
> 
> Should be debuggable :)
> 
> "mkdir bld && cd bld && ./configure --disable-werror && make" works for
> me.  config-all-devices.mak has some 80 entries.

And it works for me too. Must have been an 11pm phenomenon.

David