From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39526 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pdqov-0001NA-Re for qemu-devel@nongnu.org; Fri, 14 Jan 2011 16:04:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pdqou-0006AD-Vd for qemu-devel@nongnu.org; Fri, 14 Jan 2011 16:04:29 -0500 Received: from sj-iport-4.cisco.com ([171.68.10.86]:60818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pdqou-0006A6-RS for qemu-devel@nongnu.org; Fri, 14 Jan 2011 16:04:28 -0500 Message-ID: <4D30BA59.4030204@cisco.com> Date: Fri, 14 Jan 2011 14:04:25 -0700 From: David Ahern MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files References: <1295032341-6926-1-git-send-email-daahern@cisco.com> <1295032341-6926-3-git-send-email-daahern@cisco.com> <4D30B10A.20302@cisco.com> <4D30B650.9020703@cisco.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 01/14/11 13:57, Blue Swirl wrote: >>> That's OK, but the correct fix is to change the design of the machine >>> model to something more advanced where the unwanted objects are simply >>> not linked in, without any changes to board code. This is not so >>> trivial and also many devices are not architecturally clean yet. >> >> A lot of changes are need to obtain that goal, and I am not the right >> person to do them. Until that ideal design can be developed and >> implemented why not take a small patch that fixes the existing design? >> It's not a major change -- a very small one actually (4 files, 13 lines >> modified). > > So far the approach has been to make changes only in line with that goal. That's a shame. I'll collapse the patch series and maintain it locally then.