From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40622 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pe8HQ-0008Kf-IV
	for qemu-devel@nongnu.org; Sat, 15 Jan 2011 10:43:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Pe8HP-0002NI-E2
	for qemu-devel@nongnu.org; Sat, 15 Jan 2011 10:43:04 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:44938)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Pe8HP-0002ND-A0
	for qemu-devel@nongnu.org; Sat, 15 Jan 2011 10:43:03 -0500
Received: by wyg36 with SMTP id 36so4030494wyg.4
	for <qemu-devel@nongnu.org>; Sat, 15 Jan 2011 07:43:02 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D31C083.1050606@redhat.com>
Date: Sat, 15 Jan 2011 16:42:59 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1295032341-6926-1-git-send-email-daahern@cisco.com>
	<1295032341-6926-2-git-send-email-daahern@cisco.com>
In-Reply-To: <1295032341-6926-2-git-send-email-daahern@cisco.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 01/11] fix 'no such file' error from
	make_device_config.sh
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Ahern <daahern@cisco.com>
Cc: qemu-devel@nongnu.org

On 01/14/2011 08:12 PM, David Ahern wrote:
> make_device_config currently emits an error:
>
> make config-all-devices.mak
>    GEN   x86_64-softmmu/config-devices.mak
> /home/dsa/kvm/releases/qemu.git/make_device_config.sh: line 21: /home/dsa/kvm/releases/qe
>
> Root cause is a space in the filename (determined by Markus Armbruster). Change from Markus Armbruster<armbru@redhat.com>.
>
> Signed-off-by: David Ahern<daahern@cisco.com>
> ---
>   make_device_config.sh |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/make_device_config.sh b/make_device_config.sh
> index 596fc5b..711829c 100644
> --- a/make_device_config.sh
> +++ b/make_device_config.sh
> @@ -18,7 +18,7 @@ process_includes () {
>
>   f=$src
>   while [ -n "$f" ] ; do
> -  f=`tr -d '\r'<  $f | awk '/^include / {ORS=" "; print "'$src_dir'/" $2}'`
> +  f=`tr -d '\r'<"$f" | awk '/^include / {print "'$src_dir'/" $2}'`

Can anybody with Windows test this to make sure there are no CR woes? 
That was IIRC the reason for the strange ORS setting.

If there are, we can just change it to this:

   f=`tr -d '\r'<"$f" | awk '/^include / {printf "'$src_dir'/%s", $2}'`

Sorry for not noticing this in the previous thread.

Paolo