From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH v2 3/3] checkpatch: adjust to QEMUisms
Date: Mon, 17 Jan 2011 08:40:11 +0100 [thread overview]
Message-ID: <4D33F25B.9090504@redhat.com> (raw)
In-Reply-To: <AANLkTinH+wUEZDbkOmdyWKpsw_c6Lj2ggyRceJm3NNtf@mail.gmail.com>
On 01/15/2011 06:45 PM, Blue Swirl wrote:
> + if ($level == 0 && !$block =~ /^\s*\{/ && !$allowed) {
I'm not a Perl expert at all, but I think you need parentheses for the
argument of "!":
if ($level == 0 && !($block =~ /^\s*\{/) && !$allowed) {
Paolo
next prev parent reply other threads:[~2011-01-17 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 17:45 [Qemu-devel] [PATCH v2 3/3] checkpatch: adjust to QEMUisms Blue Swirl
2011-01-17 7:40 ` Paolo Bonzini [this message]
2011-01-17 19:37 ` [Qemu-devel] " Blue Swirl
2011-01-18 10:24 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D33F25B.9090504@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).