From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40042 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PejhI-0000fv-LU for qemu-devel@nongnu.org; Mon, 17 Jan 2011 02:40:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PejhH-0002Uv-Mi for qemu-devel@nongnu.org; Mon, 17 Jan 2011 02:40:16 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:50760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PejhH-0002Ul-IM for qemu-devel@nongnu.org; Mon, 17 Jan 2011 02:40:15 -0500 Received: by wwi18 with SMTP id 18so4749730wwi.10 for ; Sun, 16 Jan 2011 23:40:14 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4D33F25B.9090504@redhat.com> Date: Mon, 17 Jan 2011 08:40:11 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 3/3] checkpatch: adjust to QEMUisms List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel On 01/15/2011 06:45 PM, Blue Swirl wrote: > + if ($level == 0 && !$block =~ /^\s*\{/ && !$allowed) { I'm not a Perl expert at all, but I think you need parentheses for the argument of "!": if ($level == 0 && !($block =~ /^\s*\{/) && !$allowed) { Paolo