From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47137 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PelbO-0000d8-Gq
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 04:42:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PelbN-0007AF-8s
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 04:42:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PelbN-0007A5-0F
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 04:42:17 -0500
Message-ID: <4D340F4C.2020204@redhat.com>
Date: Mon, 17 Jan 2011 10:43:40 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] pci: Remove unneeded null pointer check
References: <1295114463-13806-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1295114463-13806-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

Am 15.01.2011 19:01, schrieb Stefan Weil:
> With bm == NULL, other code in the same function would crash.
> 
> This bug was reported by cppcheck:
> hw/ide/pci.c:280: error: Possible null pointer dereference: bm
> 
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Thanks, applied to the block branch.

Kevin