From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38334 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PepZy-0002ji-1c
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 08:57:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PepZx-0008Rz-8d
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 08:57:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:26020)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PepZw-0008Rv-Ui
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 08:57:05 -0500
Message-ID: <4D344AA9.3070901@redhat.com>
Date: Mon, 17 Jan 2011 14:56:57 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC][PATCH v6 01/23] Move code related to fd
	handlers into utility functions
References: <1295270117-24760-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1295270117-24760-2-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1295270117-24760-2-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, markus_mueller@de.ibm.com, marcel.mittelstaedt@de.ibm.com, qemu-devel@nongnu.org, abeekhof@redhat.com, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, Jes.Sorensen@redhat.com, Amit Shah <amit.shah@redhat.com>

   Hi,

> +/* XXX: fd_read_poll should be suppressed, but an API change is
> +   necessary in the character devices to suppress fd_can_read(). */

FYI: Amit (Cc'ed) looks at this api issue too for other reasons.

cheers,
   Gerd