From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55431 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pf7lm-00030K-V0
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 04:22:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Pf7ll-0007w0-1r
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 04:22:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34854)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Pf7lk-0007vb-OL
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 04:22:28 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0I9MRfN022289
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 18 Jan 2011 04:22:28 -0500
Message-ID: <4D355BD1.4080100@redhat.com>
Date: Tue, 18 Jan 2011 10:22:25 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch()
	statement
References: <1295284345-24524-1-git-send-email-Jes.Sorensen@redhat.com>	<1295284345-24524-3-git-send-email-Jes.Sorensen@redhat.com>
	<m3r5cain49.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3r5cain49.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, Alex.Williamson@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org

On 01/18/11 10:20, Markus Armbruster wrote:
>> diff --git a/cutils.c b/cutils.c
>> index 328738c..f2c8bbd 100644
>> --- a/cutils.c
>> +++ b/cutils.c
>> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **=
end, const char default_suffix)
>>          }
>>      }
>>      switch (toupper(d)) {
>> -    case 'B':
>> +    case STRTOSZ_DEFSUFFIX_B:
>>          mul =3D 1;
>>          if (mul_required) {
>>              goto fail;
>>          }
>>          break;
>> -    case 'K':
>> +    case STRTOSZ_DEFSUFFIX_KB:
>>          mul =3D 1 << 10;
>>          break;
>>      case 0:
>>          if (mul_required) {
>>              goto fail;
>>          }
>> -    case 'M':
>> +    case STRTOSZ_DEFSUFFIX_MB:
>>          mul =3D 1ULL << 20;
>>          break;
>> -    case 'G':
>> +    case STRTOSZ_DEFSUFFIX_GB:
>>          mul =3D 1ULL << 30;
>>          break;
>> -    case 'T':
>> +    case STRTOSZ_DEFSUFFIX_TB:
>>          mul =3D 1ULL << 40;
>>          break;
>>      default:
>=20
> And this improves what?  Certainly not clarity.
>=20
> In my opinion, the STRTOSZ_DEFSUFFIX_TB are useless chaff.  Chacun =C3=A0=
 son
> go=C3=BBt.

It cuts out lines of code, which is good, and using the macros means the
user is less likely to make a type and use a wrong character.

It's a taste issue though, I agree!

Cheers,
Jes