From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44457 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pf8js-00056E-Dn
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 05:24:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Pf8jp-0006jD-NL
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 05:24:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35745)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Pf8jp-0006in-E6
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 05:24:33 -0500
Message-ID: <4D356A5B.6020906@redhat.com>
Date: Tue, 18 Jan 2011 11:24:27 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <AANLkTinH+wUEZDbkOmdyWKpsw_c6Lj2ggyRceJm3NNtf@mail.gmail.com>
	<4D33F25B.9090504@redhat.com>
	<AANLkTi=gH2B_Liig7TB-UpeYcy5p4y5fp7_P8-YMfEUq@mail.gmail.com>
In-Reply-To: <AANLkTi=gH2B_Liig7TB-UpeYcy5p4y5fp7_P8-YMfEUq@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 3/3] checkpatch: adjust to QEMUisms
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 01/17/2011 08:37 PM, Blue Swirl wrote:
> On Mon, Jan 17, 2011 at 7:40 AM, Paolo Bonzini<pbonzini@redhat.com>  wrote:
>> On 01/15/2011 06:45 PM, Blue Swirl wrote:
>>>
>>> +                       if ($level == 0&&  !$block =~ /^\s*\{/&&
>>> !$allowed) {
>>
>> I'm not a Perl expert at all, but I think you need parentheses for the
>> argument of "!":
>
> ! has higher precedence than =~:
> http://perldoc.perl.org/perlop.html#Operator-Precedence-and-Associativity

I think that's what I meant. :)

>>   if ($level == 0&&  !($block =~ /^\s*\{/)&&  !$allowed) {
>
> Maybe instead:
> if ($level == 0&&  $block !~ /^\s*\{/&&  !$allowed) {

Yes, this too.

Paolo