From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49276 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pf9tm-0006Kx-SK for qemu-devel@nongnu.org; Tue, 18 Jan 2011 06:38:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pf9tl-0006ra-KD for qemu-devel@nongnu.org; Tue, 18 Jan 2011 06:38:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pf9tl-0006rE-DQ for qemu-devel@nongnu.org; Tue, 18 Jan 2011 06:38:53 -0500 Message-ID: <4D357C0D.5070802@redhat.com> Date: Tue, 18 Jan 2011 12:39:57 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit References: <1295345442-16218-1-git-send-email-stefanha@linux.vnet.ibm.com> <1295345442-16218-2-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1295345442-16218-2-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, "Justin M. Forbes" , Christoph Hellwig Am 18.01.2011 11:10, schrieb Stefan Hajnoczi: > Provide the "removable" qdev property bit to override the SCSI INQUIRY > removable (RMB) bit for non-CDROM devices. This will be used by USB > Mass Storage Devices, which sometimes have this guest-visible bit set > and sometimes do not. They therefore requires a means for user > configuration. > > Signed-off-by: Stefan Hajnoczi Should we print an error message when the user tries to make a CD-ROM non-removable instead of silently ignoring the option? Kevin