From: Gerd Hoffmann <kraxel@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Joerg Roedel <Joerg.Roedel@amd.com>,
Sebastian Herbszt <herbszt@gmx.de>,
Alexander Graf <agraf@suse.de>,
qemu-devel Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [PATCH 6/8] ahci: make number of ports runtime determined
Date: Tue, 18 Jan 2011 14:09:13 +0100 [thread overview]
Message-ID: <4D3590F9.7010701@redhat.com> (raw)
In-Reply-To: <4D358A3C.3060703@redhat.com>
Hi,
>> diff --git a/hw/ide/ich.c b/hw/ide/ich.c
>> index 70cb766..f242d7a 100644
>> --- a/hw/ide/ich.c
>> +++ b/hw/ide/ich.c
>> @@ -100,7 +100,7 @@ static int pci_ich9_ahci_init(PCIDevice *dev)
>>
>> msi_init(dev, 0x50, 1, true, false);
>>
>> - ahci_init(&d->ahci,&dev->qdev);
>> + ahci_init(&d->ahci,&dev->qdev, 6);
>> d->ahci.irq = d->card.irq[0];
>
> What about a qdev property instead of just hardcoding the value
> somewhere else?
That particular piece of emulated hardware (ich9-ahci) actually has 6
ports. ich7 has 4 ports. A thin hardware-specific wrapper which
hardcodes this stuff (and pci ids and maybe some other minor
differences) looks fine to me. Maybe alex should add a ich7 variant
just to prove the point ;)
cheers,
Gerd
next prev parent reply other threads:[~2011-01-18 13:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 21:13 [Qemu-devel] [PATCH 0/8] Some more AHCI work Alexander Graf
2010-12-20 21:13 ` [Qemu-devel] [PATCH 1/8] ahci: split ICH9 from core Alexander Graf
2010-12-23 8:23 ` Stefan Hajnoczi
2010-12-23 10:32 ` Alexander Graf
2010-12-27 11:51 ` Sebastian Herbszt
2010-12-20 21:13 ` [Qemu-devel] [PATCH 2/8] ahci: split ICH and AHCI even more Alexander Graf
2011-01-18 12:19 ` [Qemu-devel] " Kevin Wolf
2011-02-01 14:12 ` Alexander Graf
2010-12-20 21:13 ` [Qemu-devel] [PATCH 3/8] ahci: send init d2h fis on fis enable Alexander Graf
2011-01-18 12:25 ` [Qemu-devel] " Kevin Wolf
2011-01-18 12:42 ` Alexander Graf
2010-12-20 21:13 ` [Qemu-devel] [PATCH 4/8] ahci: use qiov instead of dma helpers Alexander Graf
2011-01-18 12:35 ` [Qemu-devel] " Kevin Wolf
2011-01-18 12:45 ` Alexander Graf
2011-01-18 13:14 ` Stefan Hajnoczi
2011-01-18 13:30 ` Kevin Wolf
2010-12-20 21:13 ` [Qemu-devel] [PATCH 5/8] ahci: Implement HBA reset Alexander Graf
2010-12-20 21:13 ` [Qemu-devel] [PATCH 6/8] ahci: make number of ports runtime determined Alexander Graf
2011-01-18 12:40 ` [Qemu-devel] " Kevin Wolf
2011-01-18 12:46 ` Alexander Graf
2011-01-18 13:33 ` Kevin Wolf
2011-01-18 13:09 ` Gerd Hoffmann [this message]
2010-12-20 21:13 ` [Qemu-devel] [PATCH 7/8] ahci: free dynamically allocated iovs Alexander Graf
2011-01-18 12:41 ` [Qemu-devel] " Kevin Wolf
2010-12-20 21:13 ` [Qemu-devel] [PATCH 8/8] ahci: fix !msi interrupts Alexander Graf
2011-01-17 14:37 ` [Qemu-devel] " Jan Kiszka
2011-01-17 16:00 ` Alexander Graf
2011-01-17 16:03 ` Jan Kiszka
2011-01-17 16:04 ` Alexander Graf
2011-01-17 16:20 ` Jan Kiszka
2011-01-17 16:33 ` Alexander Graf
2011-01-17 16:48 ` Jan Kiszka
2011-01-17 16:50 ` Alexander Graf
2011-01-18 9:08 ` Gerd Hoffmann
2011-01-18 12:05 ` Alexander Graf
2011-01-18 12:58 ` Jan Kiszka
2011-01-22 13:13 ` Aurelien Jarno
2011-01-22 14:14 ` Edgar E. Iglesias
2011-01-22 14:32 ` Alexander Graf
2011-01-22 14:40 ` Aurelien Jarno
2011-01-23 3:34 ` Edgar E. Iglesias
2011-01-22 14:28 ` Alexander Graf
2011-01-22 14:34 ` Aurelien Jarno
2011-01-18 13:02 ` Gerd Hoffmann
2011-01-17 13:25 ` [Qemu-devel] [PATCH 0/8] Some more AHCI work Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3590F9.7010701@redhat.com \
--to=kraxel@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=agraf@suse.de \
--cc=herbszt@gmx.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).