From: Anthony Liguori <anthony@codemonkey.ws>
To: Amit Shah <amit.shah@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>,
qemu list <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers
Date: Tue, 18 Jan 2011 08:19:34 -0600 [thread overview]
Message-ID: <4D35A176.3010405@codemonkey.ws> (raw)
In-Reply-To: <20110118115624.GD10526@amit-x200.redhat.com>
On 01/18/2011 05:56 AM, Amit Shah wrote:
> On (Mon) Jan 17 2011 [08:57:16], Anthony Liguori wrote:
>
>>> Also -- this patchset was prompted by a bug in qemu chardevs that
>>> freezes guests if they write faster than the chardevs can consume.
>>> What should the strategy on fixing that bug be?
>>>
>> Fix the loop API such that we're not just fixing one bug but that we
>> can address a bunch of other bugs that are out there.
>>
> But what's the right fix?
>
> * Pull in glib or some other library
> * Mimic API from some other library
>
1) get rid of poll callbacks
These kill us right now because it makes it impossible to use poll/epoll
or to use some other API.
2) switch to a single callback and an event mask
We can't do this without (1) because the can_read callback takes a
different signature. But read/write callbacks can be a single callback
(but it needs to be changed to accept an event mask).
3) allow the event mask to be changed via a new API
This gives the functionality you're looking for while making a huge
improvement to the internal API.
A quick python/perl script can probably do 90% of the work here.
Regards,
Anthony Liguori
> Amit
>
prev parent reply other threads:[~2011-01-18 14:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 15:00 [Qemu-devel] [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers Amit Shah
2011-01-13 15:00 ` [Qemu-devel] [PATCH v2 1/5] iohandlers: Avoid code duplication Amit Shah
2011-01-13 15:00 ` [Qemu-devel] [PATCH v2 2/5] iohandlers: Introduce assign_fd_handlers() and remove_fd_handlers Amit Shah
2011-01-13 15:00 ` [Qemu-devel] [PATCH v2 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually Amit Shah
2011-01-13 15:00 ` [Qemu-devel] [PATCH v2 4/5] iohandlers: Enable an iohandler only if the associated handler exists Amit Shah
2011-01-13 15:00 ` [Qemu-devel] [PATCH v2 5/5] iohandlers: Add IOHandlerOps struct Amit Shah
2011-01-13 15:09 ` [Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers Gerd Hoffmann
2011-01-13 19:17 ` Anthony Liguori
2011-01-17 10:18 ` Amit Shah
2011-01-17 14:57 ` Anthony Liguori
2011-01-17 18:30 ` Michael Roth
2011-01-18 11:56 ` Amit Shah
2011-01-18 14:19 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D35A176.3010405@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).