From: Eric Blake <eblake@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kwolf@redhat.com, Jes.Sorensen@redhat.com,
Alex.Williamson@redhat.com, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement
Date: Tue, 18 Jan 2011 09:53:14 -0700 [thread overview]
Message-ID: <4D35C57A.4040206@redhat.com> (raw)
In-Reply-To: <4D35C4E7.4080704@codemonkey.ws>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On 01/18/2011 09:50 AM, Anthony Liguori wrote:
>>> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char
>>> **end, const char default_suffix)
>>> }
>>> }
>>> switch (toupper(d)) {
> BTW, a useful change would be to accept both upper and lower case letters.
And it does, via the toupper() added earlier in the series (and which
has separately been pointed out that using qemu_toupper() might be nicer).
--
Eric Blake eblake@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2011-01-18 16:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 17:12 [Qemu-devel] [PATCH 0/2] strtosz() more cleanups Jes.Sorensen
2011-01-17 17:12 ` [Qemu-devel] [PATCH 1/2] strtosz(): Fix name confusion in use of modf() Jes.Sorensen
2011-01-17 17:12 ` [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement Jes.Sorensen
2011-01-18 9:20 ` Markus Armbruster
2011-01-18 9:22 ` Jes Sorensen
2011-01-18 15:24 ` Alex Williamson
2011-01-18 16:50 ` Anthony Liguori
2011-01-18 16:52 ` Jes Sorensen
2011-01-18 16:53 ` Eric Blake [this message]
2011-01-18 20:30 ` Anthony Liguori
2011-01-18 20:36 ` Jes Sorensen
2011-01-18 20:39 ` Anthony Liguori
2011-01-19 10:03 ` Jes Sorensen
2011-01-17 17:15 ` [Qemu-devel] Re: [PATCH 0/2] strtosz() more cleanups Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D35C57A.4040206@redhat.com \
--to=eblake@redhat.com \
--cc=Alex.Williamson@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).