From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49287 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PfEpL-0002pZ-Tx for qemu-devel@nongnu.org; Tue, 18 Jan 2011 11:56:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PfEo2-0000wB-9x for qemu-devel@nongnu.org; Tue, 18 Jan 2011 11:54:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PfEo2-0000vy-31 for qemu-devel@nongnu.org; Tue, 18 Jan 2011 11:53:18 -0500 Message-ID: <4D35C57A.4040206@redhat.com> Date: Tue, 18 Jan 2011 09:53:14 -0700 From: Eric Blake MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement References: <1295284345-24524-1-git-send-email-Jes.Sorensen@redhat.com> <1295284345-24524-3-git-send-email-Jes.Sorensen@redhat.com> <4D35C4E7.4080704@codemonkey.ws> In-Reply-To: <4D35C4E7.4080704@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig3DF512BF0F38822D78F274C3" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kwolf@redhat.com, Jes.Sorensen@redhat.com, Alex.Williamson@redhat.com, Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3DF512BF0F38822D78F274C3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/18/2011 09:50 AM, Anthony Liguori wrote: >>> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char >>> **end, const char default_suffix) >>> } >>> } >>> switch (toupper(d)) { > BTW, a useful change would be to accept both upper and lower case lette= rs. And it does, via the toupper() added earlier in the series (and which has separately been pointed out that using qemu_toupper() might be nicer)= =2E --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enig3DF512BF0F38822D78F274C3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJNNcV6AAoJEKeha0olJ0NqMxsH/RnWxcs+bJYHol7AWCKP021g 0r1kYO3nrTJLFRzsAhVziqNTtY09SSlN3d1HB3ZzID4P0ibSpO7oZSA0Ige8UcPq o1rB2Vc1qtUVU0WaaKBizO4jomTdWXHiatNxWVfRdd/W7cnBvV4ls80qbioGT3Qz 4CGqPHPqUSYzCU7dn7eoDPwyBV0F2iMSP3gsPMff3ICOfIjP7unOuX3nfQViQCdt bnzZ+EkUMg3ClMUbbVhdK5xHYiY5Ro3hB5wkOeYXgVtpKnJ6h9yn+QSpHfn5FXkk cK8/xsUrj7e1O/bv6utaJeYjt95IGAVHtrtVvOFPTSdBzMt4KIrehyMfLOr+dDQ= =IBzG -----END PGP SIGNATURE----- --------------enig3DF512BF0F38822D78F274C3--