From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43082 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PfTxq-00036r-Oz
	for qemu-devel@nongnu.org; Wed, 19 Jan 2011 04:04:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PfTxp-0001QN-7o
	for qemu-devel@nongnu.org; Wed, 19 Jan 2011 04:04:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45571)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PfTxo-0001QH-VW
	for qemu-devel@nongnu.org; Wed, 19 Jan 2011 04:04:25 -0500
Message-ID: <4D36A95A.6030209@redhat.com>
Date: Wed, 19 Jan 2011 10:05:30 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 14/19] block: insert event-tap
	to	bdrv_aio_writev() and bdrv_aio_flush().
References: <1295415904-11918-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
	<1295415904-11918-15-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
In-Reply-To: <1295415904-11918-15-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: aliguori@us.ibm.com, dlaor@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com

Am 19.01.2011 06:44, schrieb Yoshiaki Tamura:
> event-tap function is called only when it is on, and requests sent
> from device emulators.
> 
> Signed-off-by: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
> ---
>  block.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/block.c b/block.c
> index ff2795b..85bd8b8 100644
> --- a/block.c
> +++ b/block.c
> @@ -28,6 +28,7 @@
>  #include "block_int.h"
>  #include "module.h"
>  #include "qemu-objects.h"
> +#include "event-tap.h"
>  
>  #ifdef CONFIG_BSD
>  #include <sys/types.h>
> @@ -2111,6 +2112,11 @@ BlockDriverAIOCB *bdrv_aio_writev(BlockDriverState *bs, int64_t sector_num,
>      if (bdrv_check_request(bs, sector_num, nb_sectors))
>          return NULL;
>  
> +    if (bs->device_name && event_tap_is_on()) {

bs->device_name is a pointer to a char array contained in bs, so it's
never NULL. You probably mean *bs->device_name?

Kevin