From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command
Date: Wed, 19 Jan 2011 16:49:04 +0100 [thread overview]
Message-ID: <4D3707F0.3050608@redhat.com> (raw)
In-Reply-To: <20110119153544.GA6987@lst.de>
Am 19.01.2011 16:35, schrieb Christoph Hellwig:
> On Mon, Jan 17, 2011 at 06:36:15PM +0100, Kevin Wolf wrote:
>>> + .args_type = "id:s,size:l",
>>
>> size should be 'o' instead of 'l'. The latter may be too small on 32 bit
>> hosts and doesn't support convenient suffixes:
>
> o actually fails for 2GB or more for me:
>
> (qemu) resize scratch 2047
> resize scratch 2047
> (qemu)
> (qemu) resize scrarch 2048
> resize scrarch 2048
> invalid size
>
> for l these worked fine.
Hm, yeah, 'o' uses ssize_t instead of int64_t, so it's broken on a 32
bit host as well. Though I assume that you use a 64 bit host, and I
can't really see what's the problem there...
Kevin
next prev parent reply other threads:[~2011-01-19 15:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 16:20 [Qemu-devel] [PATCH 0/3] allow online resizing of block devices Christoph Hellwig
2011-01-14 16:20 ` [Qemu-devel] [PATCH 1/3] block: add resize monitor command Christoph Hellwig
2011-01-17 11:28 ` Stefan Hajnoczi
2011-01-17 15:59 ` Christoph Hellwig
2011-01-17 17:36 ` Kevin Wolf
2011-01-18 12:28 ` Christoph Hellwig
2011-01-19 15:35 ` Christoph Hellwig
2011-01-19 15:49 ` Kevin Wolf [this message]
2011-01-19 15:52 ` Christoph Hellwig
2011-01-19 16:01 ` Kevin Wolf
2011-01-19 16:31 ` Christoph Hellwig
2011-01-14 16:21 ` [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize Christoph Hellwig
2011-01-14 21:06 ` Ryan Harper
2011-01-17 9:14 ` Christoph Hellwig
2011-01-14 16:21 ` [Qemu-devel] [PATCH 3/3] virtio-blk: tell the guest about size changes Christoph Hellwig
2011-01-18 12:35 ` [Qemu-devel] [PATCH 0/3] allow online resizing of block devices Luiz Capitulino
2011-01-18 12:48 ` Christoph Hellwig
2011-01-18 13:17 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2011-01-19 17:02 [Qemu-devel] [PATCH 0/3 v2] " Christoph Hellwig
2011-01-19 17:02 ` [Qemu-devel] [PATCH 1/3] block: add resize monitor command Christoph Hellwig
2011-01-20 8:56 ` Stefan Hajnoczi
2011-01-20 9:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3707F0.3050608@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).