Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1

[Stefan Weil <weil@mail.berlios.de>]

Am 20.01.2011 15:49, schrieb Chunqiang Tang:
>> Please try to split the patches into logical parts, and use descriptive
>> subject lines for each patch.
>> E.g. adding the new sim command to qemu-io could be one patch, adding
>> the img_update (why not just update?) command to qemu-img another,
>> moving code into qemu-tool-time.c one more, etc.
>
> Will do and thank you for the detailed instructions.
>
>>> -
>>> +
>> Please do not introduce random whitespace changes in patches.
>
> Stefan Weil previously suggested removing spaces at the end of a line, 
> and
> I used a script to do that. It seems that in this example, the old code
> has multiple spaces on an empty line, which were automatically removed by
> the script.

Yes, that's a problem with some parts of the old code.
For files which you want to modify, you could remove
the spaces with your script before applying your other
modifications and create a separate patch which only
removes the superfluous spaces.

So your patch series would start with patches which
only remove spaces at line endings (and say so in the
patch descriptions). Then these changes are no longer
random whitespace changes.

Regards,
Stefan Weil